Skip to content

feat: support --exit-on-fail for comfy node install command #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bigcat88 merged 2 commits into from
Jul 27, 2025
Merged

feat: support --exit-on-fail for comfy node install command #275

bigcat88 merged 2 commits into from
Jul 27, 2025

Conversation

@ltdrdata
Copy link
Member

@ltdrdata ltdrdata commented May 18, 2025

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 18, 2025
@codecov
Copy link

codecov bot commented May 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comfy_cli/command/custom_nodes/command.py 0.00% 4 Missing ⚠️
Flag Coverage Δ
unittests 48.03% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
comfy_cli/command/custom_nodes/command.py 38.03% <0.00%> (-0.31%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot bot added the enhancement New feature or request label May 18, 2025
bigcat88
bigcat88 approved these changes Jul 27, 2025
View reviewed changes
Copy link
Contributor

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 27, 2025
@bigcat88 bigcat88 merged commit 03e0f37 into main Jul 27, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bigcat88 bigcat88 bigcat88 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ltdrdata @bigcat88